From 828b87dcc9361b18f3410f88bb71b5289d72d517 Mon Sep 17 00:00:00 2001 From: Alex Selimov Date: Sun, 29 Mar 2026 22:36:21 -0400 Subject: [PATCH] Additional code review comments --- src/properties/transport_fit.rs | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/properties/transport_fit.rs b/src/properties/transport_fit.rs index d89887d..6145a2d 100644 --- a/src/properties/transport_fit.rs +++ b/src/properties/transport_fit.rs @@ -17,22 +17,28 @@ impl SpeciesTransportData { } } - pub fn viscosity_at(&self, temp: f64) -> f64 { + pub fn viscosity_at(&self, temp: f64) -> Option { + if self.viscosities.is_empty() { + return None; + } let i_viscosity = self .viscosities .iter() .rposition(|viscosity| temp > viscosity.temp_range.0) .unwrap_or(0); - self.viscosities[i_viscosity].compute(temp) + Some(self.viscosities[i_viscosity].compute(temp)) } - pub fn conductivity_at(&self, temp: f64) -> f64 { + pub fn conductivity_at(&self, temp: f64) -> Option { + if self.conductivities.is_empty() { + return None; + } let i_conductivity = self .conductivities .iter() .rposition(|conductivity| temp > conductivity.temp_range.0) .unwrap_or(0); - self.conductivities[i_conductivity].compute(temp) + Some(self.conductivities[i_conductivity].compute(temp)) } } @@ -68,7 +74,7 @@ mod test { d: 40.0, }; - assert_delta!(fit.compute(1.0), 90.0, 1e-12); + assert_delta!(fit.compute(4.0), 60.73794361119891, 1e-12); } #[test]